Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Package maintainer guide to Core maintainer guide. #4619

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

nuclearsandwich
Copy link
Member

This rename is motivated by a desire to begin a manual / guide for maintainers of community packages in ROS 2 distributions.

The current title is overly broad, as the guide content is targeted at ROS 2 core package maintainers rather than a maintainer of any package released in ROS 2.

Renaming and redirecting articles has a cost and I know this rename isn't free. But I think it's justified in order to provide space for content aimed at community maintainers.

There's an additional commit on here of edits I made to the doc while squaring it up with its new title. Even if we don't take the rename some of those edits are worth keeping in a dedicated PR.

Most of the changes there are clarifying whether an operation is per-repository or per-package. I've gone through and updated the documentation to use "package" or "repository" when correct in context. In a couple of cases, I removed the specification entirely (particularly in front of the word "maintainer").

ROS 2 source repositories may consist of multiple packages and certain
operations are per-repository rather than per-package. I've gone through
and updated the documentation to use "package" or "repository" when
correct in context. In a couple of cases, I removed the specification
entirely (particularly in front of the word "maintainer").
This rename is motivated by a desire to begin a manual / guide for
maintainers of _community_ packages in ROS 2 distributions.

The current title is overly broad, as the guide content is targeted at
ROS 2 core package maintainers rather than a maintainer of any package
released in ROS 2.

Renaming and redirecting articles has a cost and I know this rename
isn't free. But I think it's justified in order to provide space for
content aimed at community maintainers.
Copy link

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/10427359270/artifacts/1821948923.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-4619/index.html in your favorite browser

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this rename makes sense. Everything else looks good to me, thanks!

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Aug 20, 2024
@clalancette clalancette merged commit 2f80c3f into rolling Aug 20, 2024
4 checks passed
@clalancette clalancette deleted the nuclearsandwich/core-maintainer-guide branch August 20, 2024 20:12
mergify bot pushed a commit that referenced this pull request Aug 20, 2024
* Use package and repository appropriately in context.

ROS 2 source repositories may consist of multiple packages and certain
operations are per-repository rather than per-package. I've gone through
and updated the documentation to use "package" or "repository" when
correct in context. In a couple of cases, I removed the specification
entirely (particularly in front of the word "maintainer").

* Rename "Package maintainer guide" to "Core maintainer guide".

This rename is motivated by a desire to begin a manual / guide for
maintainers of _community_ packages in ROS 2 distributions.

The current title is overly broad, as the guide content is targeted at
ROS 2 core package maintainers rather than a maintainer of any package
released in ROS 2.

Renaming and redirecting articles has a cost and I know this rename
isn't free. But I think it's justified in order to provide space for
content aimed at community maintainers.

* Move renamed guide.

(cherry picked from commit 2f80c3f)
mergify bot pushed a commit that referenced this pull request Aug 20, 2024
* Use package and repository appropriately in context.

ROS 2 source repositories may consist of multiple packages and certain
operations are per-repository rather than per-package. I've gone through
and updated the documentation to use "package" or "repository" when
correct in context. In a couple of cases, I removed the specification
entirely (particularly in front of the word "maintainer").

* Rename "Package maintainer guide" to "Core maintainer guide".

This rename is motivated by a desire to begin a manual / guide for
maintainers of _community_ packages in ROS 2 distributions.

The current title is overly broad, as the guide content is targeted at
ROS 2 core package maintainers rather than a maintainer of any package
released in ROS 2.

Renaming and redirecting articles has a cost and I know this rename
isn't free. But I think it's justified in order to provide space for
content aimed at community maintainers.

* Move renamed guide.

(cherry picked from commit 2f80c3f)
mergify bot pushed a commit that referenced this pull request Aug 20, 2024
* Use package and repository appropriately in context.

ROS 2 source repositories may consist of multiple packages and certain
operations are per-repository rather than per-package. I've gone through
and updated the documentation to use "package" or "repository" when
correct in context. In a couple of cases, I removed the specification
entirely (particularly in front of the word "maintainer").

* Rename "Package maintainer guide" to "Core maintainer guide".

This rename is motivated by a desire to begin a manual / guide for
maintainers of _community_ packages in ROS 2 distributions.

The current title is overly broad, as the guide content is targeted at
ROS 2 core package maintainers rather than a maintainer of any package
released in ROS 2.

Renaming and redirecting articles has a cost and I know this rename
isn't free. But I think it's justified in order to provide space for
content aimed at community maintainers.

* Move renamed guide.

(cherry picked from commit 2f80c3f)
clalancette pushed a commit that referenced this pull request Aug 20, 2024
)

* Use package and repository appropriately in context.

ROS 2 source repositories may consist of multiple packages and certain
operations are per-repository rather than per-package. I've gone through
and updated the documentation to use "package" or "repository" when
correct in context. In a couple of cases, I removed the specification
entirely (particularly in front of the word "maintainer").

* Rename "Package maintainer guide" to "Core maintainer guide".

This rename is motivated by a desire to begin a manual / guide for
maintainers of _community_ packages in ROS 2 distributions.

The current title is overly broad, as the guide content is targeted at
ROS 2 core package maintainers rather than a maintainer of any package
released in ROS 2.

Renaming and redirecting articles has a cost and I know this rename
isn't free. But I think it's justified in order to provide space for
content aimed at community maintainers.

* Move renamed guide.

(cherry picked from commit 2f80c3f)

Co-authored-by: Steven! Ragnarök <nuclearsandwich@users.noreply.github.com>
clalancette pushed a commit that referenced this pull request Aug 20, 2024
)

* Use package and repository appropriately in context.

ROS 2 source repositories may consist of multiple packages and certain
operations are per-repository rather than per-package. I've gone through
and updated the documentation to use "package" or "repository" when
correct in context. In a couple of cases, I removed the specification
entirely (particularly in front of the word "maintainer").

* Rename "Package maintainer guide" to "Core maintainer guide".

This rename is motivated by a desire to begin a manual / guide for
maintainers of _community_ packages in ROS 2 distributions.

The current title is overly broad, as the guide content is targeted at
ROS 2 core package maintainers rather than a maintainer of any package
released in ROS 2.

Renaming and redirecting articles has a cost and I know this rename
isn't free. But I think it's justified in order to provide space for
content aimed at community maintainers.

* Move renamed guide.

(cherry picked from commit 2f80c3f)

Co-authored-by: Steven! Ragnarök <nuclearsandwich@users.noreply.github.com>
clalancette pushed a commit that referenced this pull request Aug 20, 2024
)

* Use package and repository appropriately in context.

ROS 2 source repositories may consist of multiple packages and certain
operations are per-repository rather than per-package. I've gone through
and updated the documentation to use "package" or "repository" when
correct in context. In a couple of cases, I removed the specification
entirely (particularly in front of the word "maintainer").

* Rename "Package maintainer guide" to "Core maintainer guide".

This rename is motivated by a desire to begin a manual / guide for
maintainers of _community_ packages in ROS 2 distributions.

The current title is overly broad, as the guide content is targeted at
ROS 2 core package maintainers rather than a maintainer of any package
released in ROS 2.

Renaming and redirecting articles has a cost and I know this rename
isn't free. But I think it's justified in order to provide space for
content aimed at community maintainers.

* Move renamed guide.

(cherry picked from commit 2f80c3f)

Co-authored-by: Steven! Ragnarök <nuclearsandwich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants