binding host PID and IPC namespace to devcontainer.json. #4654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
|
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/10479375339/artifacts/1834612073. To view the resulting site:
|
fujitatomoya
commented
Aug 20, 2024
| @@ -138,6 +138,8 @@ Therefore add the following to ``.devcontainer/devcontainer.json``: | |||
| }, | |||
| "runArgs": [ | |||
| "--net=host", | |||
| "--pid=host", | |||
There was a problem hiding this comment.
This is related to https://answers.ros.org/question/296828/ros2-connectivity-across-docker-containers-via-host-driver/. having the same PID namespace can generate the GUID if DDS implementation uses the PID for GUID.
| @@ -138,6 +138,8 @@ Therefore add the following to ``.devcontainer/devcontainer.json``: | |||
| }, | |||
| "runArgs": [ | |||
| "--net=host", | |||
| "--pid=host", | |||
| "--ipc=host", | |||
There was a problem hiding this comment.
This is suggested by Fast-DDS, https://fast-dds.docs.eprosima.com/en/latest/docker/shm_docker.html. Having the same IPC namespace can allow applications in containers and host system to communicated via shared memory transport.
clalancette
approved these changes
Aug 29, 2024
clalancette
added
the
backport-all
mergify bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 1d8b5f1)
mergify bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 1d8b5f1)
mergify bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 1d8b5f1)
clalancette
pushed a commit
that referenced
this pull request
Aug 29, 2024
clalancette
pushed a commit
that referenced
this pull request
Aug 29, 2024
clalancette
pushed a commit
that referenced
this pull request
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.