-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename debians to debs everywhere. #4669
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's because "debians" specifically refers to packages for Debian, while "debs" more generally refers to packages in the .deb format (which describes at least Debian and Ubuntu). Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
added
the
backport-all
backport at reviewers discretion; from rolling to all versions
label
Aug 21, 2024
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/10494804668/artifacts/1838707713. To view the resulting site:
|
claraberendsen
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ahcorde
approved these changes
Aug 22, 2024
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
That's because "debians" specifically refers to packages for Debian, while "debs" more generally refers to packages in the .deb format (which describes at least Debian and Ubuntu). Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 7033cbe) # Conflicts: # source/Installation/Ubuntu-Install-Debs.rst
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
That's because "debians" specifically refers to packages for Debian, while "debs" more generally refers to packages in the .deb format (which describes at least Debian and Ubuntu). Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 7033cbe) # Conflicts: # source/Installation/Ubuntu-Install-Debs.rst # source/Tutorials/Demos/dummy-robot-demo.rst
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
That's because "debians" specifically refers to packages for Debian, while "debs" more generally refers to packages in the .deb format (which describes at least Debian and Ubuntu). Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 7033cbe) # Conflicts: # source/How-To-Guides.rst # source/How-To-Guides/Building-ROS-2-with-Tracing.rst # source/Installation/Ubuntu-Install-Debs.rst # source/Tutorials/Demos/dummy-robot-demo.rst
This was referenced Aug 22, 2024
ahcorde
added a commit
that referenced
this pull request
Aug 22, 2024
* Rename debians to debs everywhere. (#4669) That's because "debians" specifically refers to packages for Debian, while "debs" more generally refers to packages in the .deb format (which describes at least Debian and Ubuntu). Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 7033cbe) # Conflicts: # source/Installation/Ubuntu-Install-Debs.rst * Fixed merged Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> --------- Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Aug 22, 2024
* Rename debians to debs everywhere. (#4669) That's because "debians" specifically refers to packages for Debian, while "debs" more generally refers to packages in the .deb format (which describes at least Debian and Ubuntu). Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 7033cbe) # Conflicts: # source/Installation/Ubuntu-Install-Debs.rst # source/Tutorials/Demos/dummy-robot-demo.rst * Fixed merge Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> --------- Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Aug 22, 2024
* Rename debians to debs everywhere. (#4669) That's because "debians" specifically refers to packages for Debian, while "debs" more generally refers to packages in the .deb format (which describes at least Debian and Ubuntu). Signed-off-by: Chris Lalancette <clalancette@gmail.com> (cherry picked from commit 7033cbe) # Conflicts: # source/How-To-Guides.rst # source/How-To-Guides/Building-ROS-2-with-Tracing.rst # source/Installation/Ubuntu-Install-Debs.rst # source/Tutorials/Demos/dummy-robot-demo.rst * Fixed merge Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fixed merge Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> * Fixed merge Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> --------- Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Chris Lalancette <clalancette@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's because "debians" specifically refers to packages for Debian, while "debs" more generally refers to packages in the .deb format (which describes at least Debian and Ubuntu).
This should fix #4639 .