-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROS2-Tracing-Trace-and-Analyze fix for iron tutorial #4675
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For branch `iron`, matching `iron` branch of `tracetools_analysis` repository must be cloned. If the `master` branch is used instead, the following `rosdep install --from-paths src --ignore-src -y` command will fail and return "test_ros2trace_analysis: Cannot locate rosdep definition for [test_tracetools]" as an error message. Signed-off-by: Vincent Conus <124330598+sunoc@users.noreply.github.com>
ahcorde
requested changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should create this change on rolling.
Do you mind to retarget the change to rolling
? and include my suggestions ?
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Vincent Conus <124330598+sunoc@users.noreply.github.com>
clalancette
approved these changes
Aug 23, 2024
@Mergifyio backport jazzy rolling humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
* ROS2-Tracing-Trace-and-Analyze fix for iron For branch `iron`, matching `iron` branch of `tracetools_analysis` repository must be cloned. If the `master` branch is used instead, the following `rosdep install --from-paths src --ignore-src -y` command will fail and return "test_ros2trace_analysis: Cannot locate rosdep definition for [test_tracetools]" as an error message. Signed-off-by: Vincent Conus <124330598+sunoc@users.noreply.github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit cb5e7dc)
mergify bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
* ROS2-Tracing-Trace-and-Analyze fix for iron For branch `iron`, matching `iron` branch of `tracetools_analysis` repository must be cloned. If the `master` branch is used instead, the following `rosdep install --from-paths src --ignore-src -y` command will fail and return "test_ros2trace_analysis: Cannot locate rosdep definition for [test_tracetools]" as an error message. Signed-off-by: Vincent Conus <124330598+sunoc@users.noreply.github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit cb5e7dc)
mergify bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
* ROS2-Tracing-Trace-and-Analyze fix for iron For branch `iron`, matching `iron` branch of `tracetools_analysis` repository must be cloned. If the `master` branch is used instead, the following `rosdep install --from-paths src --ignore-src -y` command will fail and return "test_ros2trace_analysis: Cannot locate rosdep definition for [test_tracetools]" as an error message. Signed-off-by: Vincent Conus <124330598+sunoc@users.noreply.github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit cb5e7dc) # Conflicts: # source/Tutorials/Advanced/ROS2-Tracing-Trace-and-Analyze.rst
clalancette
pushed a commit
that referenced
this pull request
Aug 23, 2024
* ROS2-Tracing-Trace-and-Analyze fix for iron For branch `iron`, matching `iron` branch of `tracetools_analysis` repository must be cloned. If the `master` branch is used instead, the following `rosdep install --from-paths src --ignore-src -y` command will fail and return "test_ros2trace_analysis: Cannot locate rosdep definition for [test_tracetools]" as an error message. Signed-off-by: Vincent Conus <124330598+sunoc@users.noreply.github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit cb5e7dc)
clalancette
pushed a commit
that referenced
this pull request
Aug 23, 2024
* ROS2-Tracing-Trace-and-Analyze fix for iron For branch `iron`, matching `iron` branch of `tracetools_analysis` repository must be cloned. If the `master` branch is used instead, the following `rosdep install --from-paths src --ignore-src -y` command will fail and return "test_ros2trace_analysis: Cannot locate rosdep definition for [test_tracetools]" as an error message. Signed-off-by: Vincent Conus <124330598+sunoc@users.noreply.github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit cb5e7dc) Co-authored-by: Vincent Conus <124330598+sunoc@users.noreply.github.com>
clalancette
pushed a commit
that referenced
this pull request
Aug 23, 2024
* ROS2-Tracing-Trace-and-Analyze fix for iron For branch `iron`, matching `iron` branch of `tracetools_analysis` repository must be cloned. If the `master` branch is used instead, the following `rosdep install --from-paths src --ignore-src -y` command will fail and return "test_ros2trace_analysis: Cannot locate rosdep definition for [test_tracetools]" as an error message. Signed-off-by: Vincent Conus <124330598+sunoc@users.noreply.github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit cb5e7dc) Co-authored-by: Vincent Conus <124330598+sunoc@users.noreply.github.com>
clalancette
pushed a commit
that referenced
this pull request
Aug 23, 2024
* ROS2-Tracing-Trace-and-Analyze fix for iron For branch `iron`, matching `iron` branch of `tracetools_analysis` repository must be cloned. If the `master` branch is used instead, the following `rosdep install --from-paths src --ignore-src -y` command will fail and return "test_ros2trace_analysis: Cannot locate rosdep definition for [test_tracetools]" as an error message. Signed-off-by: Vincent Conus <124330598+sunoc@users.noreply.github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit cb5e7dc) Co-authored-by: Vincent Conus <124330598+sunoc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching
iron
branch oftracetools_analysis
repository must be cloned.If the default
master
branch is used instead, the follow-uprosdep install --from-paths src --ignore-src -y
command will fail and return a seemingly unrelated error message:test_ros2trace_analysis: Cannot locate rosdep definition for [test_tracetools]