Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2-Tracing-Trace-and-Analyze fix for iron tutorial #4675

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

sunoc
Copy link
Contributor

@sunoc sunoc commented Aug 23, 2024

Matching iron branch of tracetools_analysis repository must be cloned.

If the default master branch is used instead, the follow-up rosdep install --from-paths src --ignore-src -y command will fail and return a seemingly unrelated error message:

test_ros2trace_analysis: Cannot locate rosdep definition for [test_tracetools]

For branch `iron`, matching `iron` branch of `tracetools_analysis` repository must be cloned.

If the `master` branch is used instead, the following `rosdep install --from-paths src --ignore-src -y` command will fail and return "test_ros2trace_analysis: Cannot locate rosdep definition for [test_tracetools]" as an error message.

Signed-off-by: Vincent Conus <124330598+sunoc@users.noreply.github.com>
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should create this change on rolling.

Do you mind to retarget the change to rolling ? and include my suggestions ?

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: Vincent Conus <124330598+sunoc@users.noreply.github.com>
@clalancette clalancette merged commit cb5e7dc into ros2:iron Aug 23, 2024
4 checks passed
@clalancette
Copy link
Contributor

@Mergifyio backport jazzy rolling humble

Copy link
Contributor

mergify bot commented Aug 23, 2024

backport jazzy rolling humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 23, 2024
* ROS2-Tracing-Trace-and-Analyze fix for iron

For branch `iron`, matching `iron` branch of `tracetools_analysis` repository must be cloned.

If the `master` branch is used instead, the following `rosdep install --from-paths src --ignore-src -y` command will fail and return "test_ros2trace_analysis: Cannot locate rosdep definition for [test_tracetools]" as an error message.

Signed-off-by: Vincent Conus <124330598+sunoc@users.noreply.github.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit cb5e7dc)
mergify bot pushed a commit that referenced this pull request Aug 23, 2024
* ROS2-Tracing-Trace-and-Analyze fix for iron

For branch `iron`, matching `iron` branch of `tracetools_analysis` repository must be cloned.

If the `master` branch is used instead, the following `rosdep install --from-paths src --ignore-src -y` command will fail and return "test_ros2trace_analysis: Cannot locate rosdep definition for [test_tracetools]" as an error message.

Signed-off-by: Vincent Conus <124330598+sunoc@users.noreply.github.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit cb5e7dc)
mergify bot pushed a commit that referenced this pull request Aug 23, 2024
* ROS2-Tracing-Trace-and-Analyze fix for iron

For branch `iron`, matching `iron` branch of `tracetools_analysis` repository must be cloned.

If the `master` branch is used instead, the following `rosdep install --from-paths src --ignore-src -y` command will fail and return "test_ros2trace_analysis: Cannot locate rosdep definition for [test_tracetools]" as an error message.

Signed-off-by: Vincent Conus <124330598+sunoc@users.noreply.github.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit cb5e7dc)

# Conflicts:
#	source/Tutorials/Advanced/ROS2-Tracing-Trace-and-Analyze.rst
clalancette pushed a commit that referenced this pull request Aug 23, 2024
* ROS2-Tracing-Trace-and-Analyze fix for iron

For branch `iron`, matching `iron` branch of `tracetools_analysis` repository must be cloned.

If the `master` branch is used instead, the following `rosdep install --from-paths src --ignore-src -y` command will fail and return "test_ros2trace_analysis: Cannot locate rosdep definition for [test_tracetools]" as an error message.

Signed-off-by: Vincent Conus <124330598+sunoc@users.noreply.github.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit cb5e7dc)
clalancette pushed a commit that referenced this pull request Aug 23, 2024
* ROS2-Tracing-Trace-and-Analyze fix for iron

For branch `iron`, matching `iron` branch of `tracetools_analysis` repository must be cloned.

If the `master` branch is used instead, the following `rosdep install --from-paths src --ignore-src -y` command will fail and return "test_ros2trace_analysis: Cannot locate rosdep definition for [test_tracetools]" as an error message.

Signed-off-by: Vincent Conus <124330598+sunoc@users.noreply.github.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit cb5e7dc)

Co-authored-by: Vincent Conus <124330598+sunoc@users.noreply.github.com>
clalancette pushed a commit that referenced this pull request Aug 23, 2024
* ROS2-Tracing-Trace-and-Analyze fix for iron

For branch `iron`, matching `iron` branch of `tracetools_analysis` repository must be cloned.

If the `master` branch is used instead, the following `rosdep install --from-paths src --ignore-src -y` command will fail and return "test_ros2trace_analysis: Cannot locate rosdep definition for [test_tracetools]" as an error message.

Signed-off-by: Vincent Conus <124330598+sunoc@users.noreply.github.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit cb5e7dc)

Co-authored-by: Vincent Conus <124330598+sunoc@users.noreply.github.com>
clalancette pushed a commit that referenced this pull request Aug 23, 2024
* ROS2-Tracing-Trace-and-Analyze fix for iron

For branch `iron`, matching `iron` branch of `tracetools_analysis` repository must be cloned.

If the `master` branch is used instead, the following `rosdep install --from-paths src --ignore-src -y` command will fail and return "test_ros2trace_analysis: Cannot locate rosdep definition for [test_tracetools]" as an error message.

Signed-off-by: Vincent Conus <124330598+sunoc@users.noreply.github.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit cb5e7dc)

Co-authored-by: Vincent Conus <124330598+sunoc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants