Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests #299

Merged
merged 2 commits into from
Jun 14, 2018
Merged

Fix failing tests #299

merged 2 commits into from
Jun 14, 2018

Conversation

Martin-Idel-SI
Copy link
Contributor

@Martin-Idel-SI Martin-Idel-SI commented Jun 14, 2018 •
edited
Loading

This PR fixes a few tests that failed after yesterdays merging.

  • Some files were moved on one branch for tests running on OSX CI
  • The amount of displays now needs scrolling in the "add display" dialog. This resulted in failure of all hidden visual tests on Windows and Linux. Tests don't run (yet) on OSRF CI, but fix nevertheless

@mikaelarguedas mikaelarguedas added the in review Waiting for review (Kanban column) label Jun 14, 2018
@clalancette clalancette mentioned this pull request Jun 14, 2018
Closed
17 tasks
@Martin-Idel-SI
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

clalancette
clalancette approved these changes Jun 14, 2018
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like obvious fixes for the tests for me.

@clalancette
Copy link
Contributor

(also, seems to have fixed the build problem for me locally, so 👍 )

@mikaelarguedas mikaelarguedas merged commit db4e6e4 into ros2:ros2 Jun 14, 2018
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Jun 14, 2018
@Martin-Idel-SI Martin-Idel-SI deleted the bugfix/fix_test_includes branch June 15, 2018 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Martin-Idel-SI @clalancette @mikaelarguedas @botteroa-si