Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning in Debug mode #305

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Fix warning in Debug mode #305

merged 1 commit into from
Jun 18, 2018

Conversation

Martin-Idel-SI
Copy link
Contributor

@Martin-Idel-SI Martin-Idel-SI commented Jun 18, 2018 •
edited
Loading

This PR fixes an MS Build warning (in Debug mode) which occured after merging the map display.
(See an instance of this warning here: https://ci.ros2.org/view/nightly/job/nightly_win_deb/915/)

Also referenced in ros2/build_farmer#125

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Jun 18, 2018
@Martin-Idel-SI
Copy link
Contributor Author

CI (in Debug mode):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette clalancette merged commit 02e863b into ros2:ros2 Jun 18, 2018
@clalancette clalancette removed the in review Waiting for review (Kanban column) label Jun 18, 2018
@Martin-Idel-SI Martin-Idel-SI deleted the bugfix/fix_msbuild_warning branch June 19, 2018 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Martin-Idel-SI @clalancette @dirk-thomas