fix: destFile may be not exist #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roseduan
reviewed
Aug 2, 2023
merge.go
Outdated
| @@ -275,6 +275,15 @@ func loadMergeFiles(dirPath string) error { | |||
| // should be moved to the original data directory, and the original data files should be deleted. | |||
| for fileId := uint32(1); fileId <= mergeFinSegmentId; fileId++ { | |||
| destFile := wal.SegmentFileName(dirPath, dataFileNameSuffix, fileId) | |||
| _, err = os.Stat(destFile) | |||
There was a problem hiding this comment.
if _, err = os.Stat(destFile); os.IsNotExist(err) {
contine
}
this will be more clear?
Or you can add a utility function named FileExists(or something like this) in util/file.go.
BTW, we just skip to remove the file, but I also want to make sure is there any other logic bugs in this case?
Thanks.
There was a problem hiding this comment.
ok, I'll add a unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug destFile may be not exist.