Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename attributes to avoid conflicts #27

Closed
dzboot02 opened this issue Aug 19, 2023 · 2 comments
Closed

Rename attributes to avoid conflicts #27

dzboot02 opened this issue Aug 19, 2023 · 2 comments

Comments

@dzboot02
Copy link

If Android Leanback library is added along side with your project, app build will fail with this error:

Resource compilation failed (Failed to compile values resource file Q:\Projects\Libs\android\fading-text-view\app\build\intermediates\incremental\debug\mergeDebugResources\merged.dir\values\values.xml. Cause: java.nio.file.InvalidPathException: Illegal char <:> at index 59: com.tomerrosenfeld.fadingtextview.app-mergeDebugResources-2:/values/values.xml). Check logs for more details.

This is due to a conflict with a declared style:

<?xml version="1.0" encoding="utf-8"?>
<resources>
    <declare-styleable name="FadingTextView">
        <attr name="texts" format="reference" />
        <attr name="timeout" format="integer" />
        <attr name="shuffle" format="boolean" />
    </declare-styleable>
</resources>

The problem is with the shuffle attribute, it is already declared in the Leanback library.

@rosenpin rosenpin changed the title Failed to compile values resource Rename attributes to avoid conflicts Aug 19, 2023
@rosenpin
Copy link
Owner

We should rename the attributes to be more specific to avoid conflicts and potential conflicts with other libraries.
Consider changing to:

  • texts -> fadingTextViewTexts
  • timeout -> fadingTextViewTimeout
  • shuffle -> fadingTextViewShuffle

@dzboot02
Copy link
Author

Yes, exactly! Thanks.

ebayraktar added a commit to ebayraktar/fading-text-view that referenced this issue Dec 28, 2023
rosenpin added a commit that referenced this issue Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants