Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug-fixes identified in cylc suite #222

Merged
merged 16 commits into from
Dec 1, 2023
Merged

bug-fixes identified in cylc suite #222

merged 16 commits into from
Dec 1, 2023

Conversation

rosepearson
Copy link
Owner

@rosepearson rosepearson commented Nov 30, 2023 •
edited
Loading

Fixed:

  • Make robust to no open waterways with measured values
  • Make robust to no ocean contours in the catchment
  • Make code change
  • Update tests
    • Update / create new tests
    • Ensure these tests have the expected behavour
    • Test locally and ensure tests are passing
  • Ensure tests passing on GH Actions
  • Update documentation
    • Doc strings
    • Wiki
  • Update package (version.py & pyproject.toml) version (if needed)

@rosepearson rosepearson linked an issue Nov 30, 2023 that may be closed by this pull request
Dask improvements #208
Closed
@rosepearson rosepearson removed a link to an issue Nov 30, 2023
Dask improvements #208
Closed
@rosepearson rosepearson linked an issue Nov 30, 2023 that may be closed by this pull request
bug-fixes identified in cylc suite #223
Closed
@rosepearson rosepearson changed the title Fixing errors uncovered from the running Cylc suite bug-fixes identified in cylc suite Nov 30, 2023
@rosepearson rosepearson added this to the 1.1.4 milestone Dec 1, 2023
@rosepearson rosepearson merged commit 22bdede into main Dec 1, 2023
1 check passed
@rosepearson rosepearson deleted the 208-dask-improvements branch December 1, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.4
Development

Successfully merging this pull request may close these issues.

bug-fixes identified in cylc suite
1 participant
@rosepearson