cli: Treat an empty syncfolder as not configured #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My `syncfolder` is set to an empty string. I believe I had sync configured once and removed the folder since, leaving me with an empty string. This PR ignores empty strings and treats them as unconfigured. Without that PR, the `workspaces` folder would be resolved relative to the current dir, leading to file-not-found errors down the line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My
syncfolderis set to an empty string.I believe I had sync configured once and removed the folder since,
leaving me with an empty string.
This PR ignores empty strings and treats them as unconfigured.
Without that PR, the
workspacesfolder would be resolvedrelative to the current dir, leading to file-not-found errors down the line.