Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined org name in student invite link + community #101

Merged
merged 5 commits into from
Dec 13, 2023

Conversation

rotimi-best
Copy link
Owner

What does this PR do?

Fixes a couple of issues I saw when having a live demo with Matthew.

  1. Student can't ask question or leave comments
  2. Infinite spinner when validation of new question failed
  3. goto was undefined.

I also added a couple of improvements:

  1. Admins can delete questions they created or the ones student created
  2. Students can now delete their own questions
  3. Snackbar notification when something is deleted

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Open LMS
  • Go to community
  • Ask a question
  • Leave comments

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the ClassroomIO Docs if changes were necessary

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 1:03pm
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 1:03pm
landingpage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 1:03pm

Copy link

github-actions bot commented Dec 13, 2023

Thank you for following the naming conventions for pull request titles! 🙏

@rotimi-best rotimi-best changed the title fix: undefine org name in student invite link + community fix: undefined org name in student invite link + community Dec 13, 2023
@rotimi-best rotimi-best merged commit aa2f7c5 into main Dec 13, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant