Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: finished the explore courses of the LMS page #454

Open
wants to merge 5 commits into
base: pathway/backendIntegration
Choose a base branch
from

Conversation

Chifez
Copy link
Collaborator

@Chifez Chifez commented Aug 30, 2024

What does this PR do?

This PR adds the pathway course to the explore page of the LMS

Fixes # (place issue number here without bracket)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the ClassroomIO Docs if changes were necessary

Copy link

github-actions bot commented Aug 30, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@@ -107,7 +107,8 @@ export async function fetchPathways(profileId: string | undefined, orgId: string
console.log('pathwaywthcourse', courses);
return {
...pathway,
pathway_course: courses // Rename pathway_course to courses
pathway_course: courses, // Rename pathway_course to courses
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why this comment is here?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chifez following up here...

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cio-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 9:36am
cio-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 9:36am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants