Fix anchor links in HTML mail (#8632)

roundcube · Jul 30, 2022 · 5c4e188 · 5c4e188
1 parent 3cfbae2
commit 5c4e188
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 - Advanced mail search syntax with more possibilities (without UI) (#8502)
 - Fix various PHP 8.1 warnings (#8628)
 - Password: Remove references to %c variable that has been removed before (#8633)
+- Fix anchor links in HTML mail (#8632)
 
 ## Release 1.6.0
 

diff --git a/program/lib/Roundcube/rcube_washtml.php b/program/lib/Roundcube/rcube_washtml.php
@@ -359,15 +359,18 @@ private function wash_attribs($node)
                         $out = $value;
                     }
                 }
-                else if ($this->_css_prefix !== null && in_array($key, ['id', 'class', 'for'])) {
+                else if ($this->_css_prefix !== null
+                    && (in_array($key, ['id', 'class', 'for']) || ($key == 'name' && $node->nodeName == 'a'))
+                ) {
                     $out = preg_replace('/(\S+)/', $this->_css_prefix . '\1', $value);
                 }
                 else if ($key) {
                    $out = $value;
                 }
 
                 if ($out !== null && $out !== '') {
-                    $result .= ' ' . $attr->nodeName . '="' . htmlspecialchars($out, ENT_QUOTES | ENT_SUBSTITUTE, $this->config['charset']) . '"';
+                    $v = htmlspecialchars($out, ENT_QUOTES | ENT_SUBSTITUTE, $this->config['charset']);
+                    $result .= " {$attr->nodeName}=\"{$v}\"";
                 }
                 else if ($value) {
                     $washed[] = htmlspecialchars($attr->nodeName, ENT_QUOTES, $this->config['charset']);

diff --git a/tests/Framework/Washtml.php b/tests/Framework/Washtml.php
@@ -664,6 +664,13 @@ function test_css_prefix()
         $this->assertStringContainsString('for="testmy-other-id"', $washed);
         $this->assertStringContainsString('href="#testmy-id"', $washed);
         $this->assertStringContainsString('class="testmy-class1 testmy-class2"', $washed);
+
+        // Make sure the anchor name is prefixed too
+        $html = '<p><a href="#a">test link</a></p><a name="a">test anchor</a>';
+        $washed = $washer->wash($html);
+
+        $this->assertStringContainsString('href="#testa"', $washed);
+        $this->assertStringContainsString('name="testa"', $washed);
     }
 
     /**