Add support for more zone calls with a break out to a zone structure. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a project I'm working on, I needed the ability to update the default zone. Rather than making my own, I decided to update your project to support using the newer zone settings and additional methods.
In testing the update/add methods, I found that firewalld errors with
INVALID_TYPE: '['4242', 'udp']' not of type <class 'tuple'>, but <class 'list'>. I'm guessing this is a newer firewalld requirement of dbus messages, and found that the dbus project has an issue to support it at godbus/dbus#329. With this bug, I decided to add support for the other methods.