Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: FEAT: Array column should be filterable #1389

Merged
merged 7 commits into from
Aug 31, 2023
Merged

fix: FEAT: Array column should be filterable #1389

merged 7 commits into from
Aug 31, 2023

Conversation

rishi-raj-jain
Copy link
Contributor

fix: #1382
/claim #1382

@vercel
Copy link

vercel bot commented Aug 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
rowy-typedoc ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2023 9:07pm

@algora-pbc algora-pbc bot mentioned this pull request Aug 20, 2023
Closed
@vercel
Copy link

vercel bot commented Aug 20, 2023

@rishi-raj-jain is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

@rishi-raj-jain
Copy link
Contributor Author

@shamsmosowi @il3ven

I figured out that in and not-in don't work when we want to filter when the filter value is an array itself.

Only, ==, !=, array-contains and array-contains-any are the supported methods as I gather from that link + testing in a simple demo.js file with the following: adding a array to your firestore, and querying the same (for in & not-in) reveal the same as above as well.

il3ven
il3ven requested changes Aug 21, 2023
View reviewed changes
src/components/fields/Array/index.tsx Outdated Show resolved Hide resolved
src/components/fields/Array/SideDrawerField/index.tsx Outdated Show resolved Hide resolved
src/hooks/useFirestoreCollectionWithAtom.ts Show resolved Hide resolved
Rishi Raj Jain and others added 3 commits August 22, 2023 02:13
@rishi-raj-jain rishi-raj-jain requested a review from il3ven August 21, 2023 21:07
@rishi-raj-jain
Copy link
Contributor Author

@il3ven

This is ready for review.

il3ven
il3ven approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@il3ven il3ven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me. I'll merge it soon.

@rishi-raj-jain
Copy link
Contributor Author

@il3ven @shamsmosowi @harinij

Did you get a chance at it?

@il3ven
Copy link
Member

il3ven commented Aug 29, 2023

Did you get a chance at it?

Hey, we have been busy with other work. This PR is approved and I will merge it soon. The bounty will be yours.

@rishi-raj-jain
Copy link
Contributor Author

Oh okay, appreciate the confirmation!

@shamsmosowi shamsmosowi merged commit 4a84523 into rowyio:develop Aug 31, 2023
@rishi-raj-jain rishi-raj-jain deleted the develop branch August 31, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@il3ven il3ven il3ven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rishi-raj-jain @il3ven @shamsmosowi