Allow column reordering #68
Conversation
|
what's status of this? |
|
I at least have heard nothing since submitting the PR, and have in fact been considering actively forking this repo in order to make my own life easier. @roylee0704, are you still actively developing this project? |
|
@eemeli hey, I'm sorry that this PR has been sitting here for 4 months, that's way too long! Personally I started using styled-components, which didn't jive with this library anymore, so I wasn't using it anymore. I'll review this PR today, thanks a lot! |
| @@ -1,18 +1,19 @@ | |||
| import style from 'flexboxgrid'; | |||
There was a problem hiding this comment.
Any reason why this statement moved?
There was a problem hiding this comment.
I find it's usually clearer to group the external imports separate from the internal ones, that's all.
test/components/Col.spec.js
Outdated
| @@ -17,6 +17,11 @@ describe('Col', () => { | |||
| expect(className).toContain(style['col-lg-4']); | |||
| }); | |||
|
|
|||
| it('Should add "first-*" class if "first" property is set', () => { | |||
| renderer.render(<Col first='md'/>); | |||
There was a problem hiding this comment.
Use double quotes for prop values (<Col first="md" />), I think this is the only reason why tests fail.
|
@silvenon do you know when we can expect a release to NPM with those changes? |
|
@pokonski not sure yet. The problem is that I discovered some bugs (i.e. some new features don't work) which I need to fix first and add more tests, but it shouldn't take long. Also, I don't think I have releasing powers, so the release time is not entirely up to me. 😕 But I respond to mentions, so feel free to ping me occasionally, I like healthy pressure. 😉 |
|
Sure, no worries. Just wanted to know when to expect it, cheers! |
|
Hopefully by the end of this week. 😉 |
|
What happened to this? |
|
@vemundeldegard check if there have been any releases since 13 Feb 2017 (that's when this was merged). If there have, it's released. Probably not documented, though, feel free to document this and send a PR. |
This fixes #22 by moving the
firstandlastprops fromRowtoCol, as they are inflexboxgrid.css.To verify that they work together, I've a build here that has this and PR #66 both merged, and includes the
lib/build artifacts.