Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

support RPN proposals testing #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

w-hc
Copy link

@w-hc w-hc commented Aug 11, 2018

Support single GPU and multi GPU testing on RPN proposals

Do not support RPN only training.
Cases such as

  1. training only the RPN branch
  2. training on pre-computed proposals

require restructuring model_builder.py quite a bit.
@roytseng-tw you should call the shots

@qinhaifangpku
Copy link

Hi, thanks for your work.

But I did not see these codes in the master branch?

@w-hc
Copy link
Author

w-hc commented Oct 6, 2018

This pull request is not merged.

@qinhaifangpku
Copy link

This pull request is not merged.
I see. How I can use them?
Cause I want to generate the proposal from a mask rcnn trained model.

@qinhaifangpku
Copy link

This pull request is not merged.

and then train the model from the precompute proposals.

@w-hc
Copy link
Author

w-hc commented Oct 6, 2018

@qinhaifangpku
Copy link

https://stackoverflow.com/questions/6022302/how-to-apply-unmerged-upstream-pull-requests-from-other-forks-into-my-fork

Maybe this can help.

Okay, Thanks for your kindly help.
I saw your repository has many branches. I wonder which branch and commit should I merge to the roys' master branch will make the rpn-testing work?

@w-hc
Copy link
Author

w-hc commented Oct 6, 2018

I created a separate branch just for this pull request. It's called rpn-testing
screen shot 2018-10-05 at 21 41 08

@qinhaifangpku
Copy link

I created a separate branch just for this pull request. It's called testing
screen shot 2018-10-05 at 21 41 08

I see.

Thanks again!

@qinhaifangpku
Copy link

I created a separate branch just for this pull request. It's called rpn-testing
screen shot 2018-10-05 at 21 41 08

Hi, I wonder if the model can be trained with the precomputed proposals and just train the mask branch and not update the box branch?

@w-hc
Copy link
Author

w-hc commented Oct 8, 2018

This codebase does not support Fast-RCNN training (the one you described) or RPN-only training. Both require restructuring model_builder.py. I did not do this pull request since it is better for the author himself to decide on this.

Also, _compute_targets in roidb.py has a behavior difference compared to fast rcnn assignment policy regarding crowd. I would say it involves a bit of testing to make sure there is no bug.

@qinhaifangpku
Copy link

Support single GPU and multi GPU testing on RPN proposals

Do not support RPN only training.
Cases such as

  1. training only the RPN branch
  2. training on pre-computed proposals

require restructuring model_builder.py quite a bit.
@roytseng-tw you should call the shots

Hi, I wonder if there we could test the bbox and mask by given proposals?

Thanks for your help in advance!

@w-hc
Copy link
Author

w-hc commented Oct 9, 2018

Some slight modifications will make it possible.
screen shot 2018-10-09 at 11 15 34
You might need to sprinkle a few more changes here and there down the road. But the spirit is true.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants