fix(fmt): do not panic when no named arg (foundry-rs#9114)

rplusq · Nov 29, 2024 · a0236f2 · a0236f2
1 parent 982f5a7
commit a0236f2
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 2 deletions.
diff --git a/crates/fmt/src/formatter.rs b/crates/fmt/src/formatter.rs
@@ -2340,8 +2340,11 @@ impl<W: Write> Visitor for Formatter<'_, W> {
             ""
         };
         let closing_bracket = format!("{prefix}{}", "}");
-        let closing_bracket_loc = args.last().unwrap().loc.end();
-        write_chunk!(self, closing_bracket_loc, "{closing_bracket}")?;
+        if let Some(arg) = args.last() {
+            write_chunk!(self, arg.loc.end(), "{closing_bracket}")?;
+        } else {
+            write_chunk!(self, "{closing_bracket}")?;
+        }
 
         Ok(())
     }

diff --git a/crates/fmt/testdata/Repros/fmt.sol b/crates/fmt/testdata/Repros/fmt.sol
@@ -144,3 +144,18 @@ contract IfElseTest {
         }
     }
 }
+
+contract DbgFmtTest is Test {
+    function test_argsList() public {
+        uint256 result1 = internalNoArgs({});
+        result2 = add({a: 1, b: 2});
+    }
+
+    function add(uint256 a, uint256 b) internal pure returns (uint256) {
+        return a + b;
+    }
+
+    function internalNoArgs() internal pure returns (uint256) {
+        return 0;
+    }
+}
diff --git a/crates/fmt/testdata/Repros/original.sol b/crates/fmt/testdata/Repros/original.sol
@@ -143,3 +143,18 @@ contract IfElseTest {
          }
      }
 }
+
+contract DbgFmtTest is Test {
+    function test_argsList() public {
+        uint256 result1 = internalNoArgs({});
+        result2 = add({a: 1, b: 2});
+    }
+
+    function add(uint256 a, uint256 b) internal pure returns (uint256) {
+        return a + b;
+    }
+
+    function internalNoArgs() internal pure returns (uint256) {
+        return 0;
+    }
+}