transaction.run() doesn't raise an error if it fails because of not enough disk space

[bcl]

I ran into this while checking the dnf5 branch of lorax against Fedora 40 in a VM without enough disk space. I'm using python3-libdnf5-5.1.8-1.fc40.x86_64.

If there isn't enough space to download the rpms it will raise an error as expected.
But if there is enough for the download, but not enough to install them, transaction.run() returns without raising an error. I also checked transaction.get_problems() and it doesn't indicate a problem.

[jan-kolarik]

Hi, I was checking the situation compared to the dnf4 and it seems we are not setting the RPMPROB_FILTER_DISKSPACE filter to get those problems from the RPM transaction run in libdnf5::rpm::Transaction::run().

[m-blaha]

I did some testing and here's what I've found:

• The transaction.get_problems() doesn't have the best name. It's actually a bit misleading since it only returns problems found during resolving. And it doesn't return a list of problems, just flags indicating the types of problems encountered (like package not found, package excluded, etc.). To get the actual resolving problems, you need to use the transaction.get_resolve_logs_as_strings() or transaction.get_resolve_logs() functions.
• In case of insufficient disk space, transaction.run() returns the value 5, which corresponds to the Transaction::TransactionRunResult::ERROR_RPM_RUN enum value. Unfortunately, this enum class is not exported to Python bindings. (Export Transaction::TransactionRunResult::ERROR_RPM_RUN enum class to Python bindings #1095)
• To get more info about RPM transaction problems, there's the transaction.get_transaction_problems() method. It returns a vector of strings that's similar to what dnf5 would print on the command line. For example:
  [
  'installing package glibc-2.37-14.fc38.x86_64 needs 2MB more space on the / filesystem',
  'installing package acpi-1.7-20.fc38.x86_64 needs 2MB more space on the / filesystem'
  ]

[m-blaha]

Sorry for the confusion. The required TransactionRunResult enum class is indeed exported to python. To handle errors during transaction run (including not enough disk space) you need to do something like:

run_result = transaction.run()
if run_result != libdnf5.base.Transaction.TransactionRunResult_SUCCESS:
    for problem in transaction.get_transaction_problems():
        print(problem)

[bcl]

Thanks, that works great!