Skip to content

Commit

Permalink
Fixed issue - #2
Browse files Browse the repository at this point in the history
  • Loading branch information
rpocklin committed Aug 23, 2015
1 parent 2599572 commit 42fd6e1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ Example markup:

## History

* 0.9.3 Changed `Number.isNaN` to use `!angular.isNumber` instead (original function not available in all browsers yet) (see [#2](/../../issues/2)).
* 0.9.2 Fixed error when not defining `when-not-visible` attributes and updated NG Docs (see [#1](/../../issues/1)).
* 0.9.1 Removed (incorrectly) namespaced events, not supported in JQ-Lite.
* 0.9.0 Fixed event unbinding when removing bound elements from the DOM.
Expand Down
2 changes: 1 addition & 1 deletion dist/angular-scroll-animate.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ angular.module('angular-scroll-animate', []).directive('whenVisible', ['$documen

var delayPercent = parseFloat(scope.delayPercent);

if ((Number.isNaN(delayPercent)) || (delayPercent < 0 || delayPercent > 1)) {
if (!angular.isNumber(delayPercent) || (delayPercent < 0 || delayPercent > 1)) {
throw new Error('Directive: angular-scroll-animate \'delay-percent\' attribute must be a decimal fraction between 0 and 1.');
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/angular-scroll-animate.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ angular.module('angular-scroll-animate', []).directive('whenVisible', ['$documen

var delayPercent = parseFloat(scope.delayPercent);

if ((Number.isNaN(delayPercent)) || (delayPercent < 0 || delayPercent > 1)) {
if (!angular.isNumber(delayPercent) || (delayPercent < 0 || delayPercent > 1)) {
throw new Error('Directive: angular-scroll-animate \'delay-percent\' attribute must be a decimal fraction between 0 and 1.');
}
}
Expand Down

0 comments on commit 42fd6e1

Please sign in to comment.