Fix resolve_connection deprecation #304
#305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Connection context manager in rq is deprecated. When a connection is explicitly passed to the Scheduler avoid using the manager and triggering a warning.
|
Hi there, do you mind rerunning the tests on this PR? RQ v2.0 will be released soon so I'd like to make a new release that makes rq-scheduler compatible with RQ v2.0 |
I believe that dfa1188 fixes the issue and omits usage of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Connection context manager in rq is deprecated. When a connection is explicitly passed to the Scheduler avoid using the manager and triggering a warning.
Fixes #304