Proposal for passing a structure to ACL checking routines #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For now this helper only introduce the `new_request` function that (stupidly, without freeing memory) create a new request base on a `struct request` members. * acl-helpers header file introduce macro `USER_ONLY_REQUEST` that allow previous tests to work with as few modifications as possible (by just passing _username_ to the check function)
…e user. * The struct request is meant to be used by acl that requires _full_ information requested by remote user (command, subcommand, args, ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to efficiently create an external ACL checking function, it would be really convenient to have access to the full request made by the remote user.
The structure I've created here allow access to
This could allow further development of a very generic external ACL checking function that has access to all those informations to allow or deny access.