Fix false positive on Credo.Check.Readability.PredicateFunctionNames

Refs #1100
rrrene · Jan 2, 2024 · 491f8d5 · 491f8d5
1 parent bb43348
commit 491f8d5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/credo/check/readability/predicate_function_names.ex b/lib/credo/check/readability/predicate_function_names.ex
@@ -93,7 +93,7 @@ defmodule Credo.Check.Readability.PredicateFunctionNames do
     issues
   end
 
-  defp issues_for_name(_op, name, meta, issues, issue_meta) do
+  defp issues_for_name(op, name, meta, issues, issue_meta) do
     name = to_string(name)
 
     cond do
@@ -103,7 +103,7 @@ defmodule Credo.Check.Readability.PredicateFunctionNames do
           | issues
         ]
 
-      String.starts_with?(name, "is_") ->
+      String.starts_with?(name, "is_") && op != :defmacro ->
         [issue_for(issue_meta, meta[:line], name, :only_predicate) | issues]
 
       true ->

diff --git a/test/credo/check/readability/predicate_function_names_test.exs b/test/credo/check/readability/predicate_function_names_test.exs
@@ -31,6 +31,16 @@ defmodule Credo.Check.Readability.PredicateFunctionNamesTest do
     |> refute_issues()
   end
 
+  test "it should NOT report a violation with defmacro" do
+    """
+    defmacro is_user(cookie) do
+    end
+    """
+    |> to_source_file
+    |> run_check(@described_check)
+    |> refute_issues()
+  end
+
   test "it should NOT report a violation with quote" do
     ~S'''
     defmodule ElixirScript.FFI do