Add titles-only RSS feed #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrrene
requested changes
Mar 26, 2017
web/controllers/feed_controller.ex
Outdated
| @@ -11,8 +11,13 @@ defmodule ElixirStatus.FeedController do | |||
| |> send_file(200, "priv/static/images/github/#{user_name}.jpg") | |||
| end | |||
|
|
|||
| def rss(conn, _params) do | |||
| def full_feed(conn, _params) do | |||
There was a problem hiding this comment.
Please revert all changes to this function.
| @@ -23,7 +23,8 @@ | |||
| <span class="sidebar-nav-item sidebar-nav-item--text"><%= gettext "You can follow via" %></span> | |||
| <a class="sidebar-nav-item no-hover-decoration" href="http://elixirweekly.net/" target="_blank"><span class="badge badge--new">NEW!</span> <span class="hover-decoration">ElixirWeekly</span></a> | |||
| <a class="sidebar-nav-item" href="https://twitter.com/elixirstatus" target="_blank">Twitter</a> | |||
| <a class="sidebar-nav-item" href="/rss">RSS</a> | |||
| <a class="sidebar-nav-item" href="/rss">RSS (full)</a> | |||
There was a problem hiding this comment.
Please revert all changes to this file.
web/controllers/feed_controller.ex
Outdated
| postings = Posting.published | ||
| render(conn, "rss.xml", postings: postings.entries) | ||
| render(conn, "full.xml", postings: postings.entries) |
There was a problem hiding this comment.
Please name all templates like their functions.
web/controllers/feed_controller.ex
Outdated
| render(conn, "full.xml", postings: postings.entries) | ||
| end | ||
|
|
||
| def titles_feed(conn, _params) do |
There was a problem hiding this comment.
Please rename titles_feed to rss_titles_only.
web/router.ex
Outdated
| @@ -39,7 +39,9 @@ defmodule ElixirStatus.Router do | |||
| get "/", PostingController, :index | |||
| get "/u/:user_name", PostingController, :user | |||
|
|
|||
| get "/rss", FeedController, :rss | |||
| get "/rss", FeedController, :full_feed | |||
| get "/rss-titles", FeedController, :titles_feed | |||
There was a problem hiding this comment.
Please rename rss-titles to rss-titles-only
web/controllers/feed_controller.ex
Outdated
|
|
||
| def titles_feed(conn, _params) do | ||
| postings = Posting.published | ||
| render(conn, "titles.xml", postings: postings.entries) |
There was a problem hiding this comment.
Please rename rss_titles_only.xml.
|
@rrrene Thanks for the review, and apologies for the delay. Have addressed all feedback. Since the titles-only RSS feed is no longer linked anywhere, it's not discoverable by browsing the site. Should it be linked somewhere or no? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a titles-only RSS feed accessible at
/rss-titlesto complement the full RSS feed available at/rss.Sidebar now looks like this:
Addresses #45.