Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.10 to test suite for github actions #101

Merged
merged 7 commits into from
Dec 10, 2021
Merged

Conversation

JBGreisman
Copy link
Member

Looking ahead, it makes sense to include this in our test suite to preemptively catch any issues

@JBGreisman JBGreisman added the version Version issues label Oct 8, 2021
@JBGreisman
Copy link
Member Author

Blocked by numpy/numpy#20039 for now.

@JBGreisman
Copy link
Member Author

JBGreisman commented Dec 9, 2021

This PR now seems good to go to me. The only problem is that pytorch, which is a requirement in our [dev] build does not support python3.10 yet. As such, a call to pip install -e .[dev] would currently fail if called using python3.10.

I'm not sure if the above failure mode should keep us from updating to support python 3.10 though.

Copy link
Member

@kmdalton kmdalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any serious issues with this PR. I don't think it is very likely the dev build issue will affect users. If it does, hopefully they'll submit an issue.

However, I do wonder whether you can replace python -m pip .... with pip ... in these yaml files. I'm guessing they are written this way for a reason, but if we could pip ... it'd be slightly cleaner.

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2021

Codecov Report

Merging #101 (eb41bc8) into main (1c180ae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #101   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files          41       41           
  Lines        1571     1571           
=======================================
  Hits         1551     1551           
  Misses         20       20           
Flag Coverage Δ
unittests 98.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c180ae...eb41bc8. Read the comment docs.

@JBGreisman JBGreisman merged commit 9e5033a into main Dec 10, 2021
@JBGreisman JBGreisman deleted the python3.10 branch December 10, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version Version issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants