-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python 3.10 to test suite for github actions #101
Conversation
Blocked by numpy/numpy#20039 for now. |
3fe88ea
to
27a8aa2
Compare
This PR now seems good to go to me. The only problem is that I'm not sure if the above failure mode should keep us from updating to support python 3.10 though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any serious issues with this PR. I don't think it is very likely the dev
build issue will affect users. If it does, hopefully they'll submit an issue.
However, I do wonder whether you can replace python -m pip ....
with pip ...
in these yaml
files. I'm guessing they are written this way for a reason, but if we could pip ...
it'd be slightly cleaner.
Codecov Report
@@ Coverage Diff @@
## main #101 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 41 41
Lines 1571 1571
=======================================
Hits 1551 1551
Misses 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Looking ahead, it makes sense to include this in our test suite to preemptively catch any issues