Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer pytorch installation to example notebook to speed up binder launch #125

Merged
merged 3 commits into from
Jan 20, 2022

Conversation

JBGreisman
Copy link
Member

PyTorch is a very large package, and it seems likely to be the culprit for slowing down the binder launch (regardless of whether a cached docker image is found; #123). This PR defers installation of pytorch to the relevant example notebook. This should decrease the size of the docker image and speed things up, while still ensuring the "robust loss function" example runs.

@JBGreisman JBGreisman added the documentation Issue related to documentation label Jan 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2022

Codecov Report

Merging #125 (a6b38a5) into main (d6a3753) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files          41       41           
  Lines        1571     1571           
=======================================
  Hits         1551     1551           
  Misses         20       20           
Flag Coverage Δ
unittests 98.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a3753...a6b38a5. Read the comment docs.

@JBGreisman JBGreisman merged commit 4405c9d into main Jan 20, 2022
@JBGreisman JBGreisman deleted the quickbinder branch January 20, 2022 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants