Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation build by lowering jinja2 version #202

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Conversation

JBGreisman
Copy link
Member

This is a quick fix to the documentation build. There is a current issue with sphinx due to a newer version of Jinja2 (readthedocs/readthedocs.org#9037 (comment)).

After this fix, I'll look into making a more future-proof documentation build -- might require updating to using a more recent Python version when building documentation.

@JBGreisman JBGreisman added bug Something isn't working documentation Issue related to documentation labels Feb 7, 2023
@JBGreisman
Copy link
Member Author

This fix corrects documentation builds locally -- our current CI doesn't explicitly test the build of the documentation, and it would be a good idea to add such a check in the future.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Merging #202 (0719bff) into main (e919c77) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files          45       45           
  Lines        1803     1803           
=======================================
  Hits         1774     1774           
  Misses         29       29           
Flag Coverage Δ
unittests 98.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Issue related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants