Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

will no longer fail for insanely small i/sigma #46

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Conversation

kmdalton
Copy link
Member

@kmdalton kmdalton commented Jan 29, 2021

I updated the French Wilson algorithm so that it wouldn't output NaNs for very small values of I/SigI, and I updated some tolerances in the test. I made them a little bit looser. Now we have to agree within %5 to the table in the paper, and 95% of the reflections must be within 2% of the values from PHENIX. I also got rid of unused posterior functions.

@codecov-io
Copy link

Codecov Report

Merging #46 (e7b8c8f) into master (a20d6c0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   99.17%   99.17%   -0.01%     
==========================================
  Files          34       34              
  Lines        1333     1330       -3     
==========================================
- Hits         1322     1319       -3     
  Misses         11       11              
Flag Coverage Δ
unittests 99.17% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...alspaceship/algorithms/scale_merged_intensities.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a20d6c0...e7b8c8f. Read the comment docs.

@kmdalton kmdalton merged commit 77545d6 into master Jan 29, 2021
@kmdalton kmdalton deleted the frenched_wilson branch January 29, 2021 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants