add support for generators to rs.concat #74
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rs.concat
does not support generators whereaspd.concat
does. The reasonrs
does not support them, is that the control flow that checks whether the arguments are isomorphous specifically indexes the first element in the passed sequence. This only works for subscriptable objects. Instead, implementing this control flow usingitertools.tee
allows us to bypass the requirement that the passed sequence be subscriptable.