Fix skewed middleware benchmarks (#165)

rs · Feb 9, 2024 · eacc8e8 · eacc8e8
1 parent 9297f15
commit eacc8e8
Showing 1 changed file with 15 additions and 18 deletions.
diff --git a/bench_test.go b/bench_test.go
@@ -29,33 +29,31 @@ const (
 )
 
 func BenchmarkWithout(b *testing.B) {
-	res := FakeResponse{http.Header{}}
+	resps := makeFakeResponses(b.N)
 	req, _ := http.NewRequest(http.MethodGet, dummyEndpoint, nil)
 
 	b.ReportAllocs()
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
-		clear(res.header)
-		testHandler.ServeHTTP(res, req)
+		testHandler.ServeHTTP(resps[i], req)
 	}
 }
 
 func BenchmarkDefault(b *testing.B) {
-	res := FakeResponse{http.Header{}}
+	resps := makeFakeResponses(b.N)
 	req, _ := http.NewRequest(http.MethodGet, dummyEndpoint, nil)
 	req.Header.Add(headerOrigin, dummyOrigin)
 	handler := Default().Handler(testHandler)
 
 	b.ReportAllocs()
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
-		clear(res.header)
-		handler.ServeHTTP(res, req)
+		handler.ServeHTTP(resps[i], req)
 	}
 }
 
 func BenchmarkAllowedOrigin(b *testing.B) {
-	res := FakeResponse{http.Header{}}
+	resps := makeFakeResponses(b.N)
 	req, _ := http.NewRequest(http.MethodGet, dummyEndpoint, nil)
 	req.Header.Add(headerOrigin, dummyOrigin)
 	c := New(Options{
@@ -66,13 +64,12 @@ func BenchmarkAllowedOrigin(b *testing.B) {
 	b.ReportAllocs()
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
-		clear(res.header)
-		handler.ServeHTTP(res, req)
+		handler.ServeHTTP(resps[i], req)
 	}
 }
 
 func BenchmarkPreflight(b *testing.B) {
-	res := FakeResponse{http.Header{}}
+	resps := makeFakeResponses(b.N)
 	req, _ := http.NewRequest(http.MethodOptions, dummyEndpoint, nil)
 	req.Header.Add(headerOrigin, dummyOrigin)
 	req.Header.Add(headerACRM, http.MethodGet)
@@ -81,13 +78,12 @@ func BenchmarkPreflight(b *testing.B) {
 	b.ReportAllocs()
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
-		clear(res.header)
-		handler.ServeHTTP(res, req)
+		handler.ServeHTTP(resps[i], req)
 	}
 }
 
 func BenchmarkPreflightHeader(b *testing.B) {
-	res := FakeResponse{http.Header{}}
+	resps := makeFakeResponses(b.N)
 	req, _ := http.NewRequest(http.MethodOptions, dummyEndpoint, nil)
 	req.Header.Add(headerOrigin, dummyOrigin)
 	req.Header.Add(headerACRM, http.MethodGet)
@@ -97,13 +93,14 @@ func BenchmarkPreflightHeader(b *testing.B) {
 	b.ReportAllocs()
 	b.ResetTimer()
 	for i := 0; i < b.N; i++ {
-		clear(res.header)
-		handler.ServeHTTP(res, req)
+		handler.ServeHTTP(resps[i], req)
 	}
 }
 
-func clear(h http.Header) {
-	for k := range h {
-		delete(h, k)
+func makeFakeResponses(n int) []*FakeResponse {
+	resps := make([]*FakeResponse, n)
+	for i := 0; i < n; i++ {
+		resps[i] = &FakeResponse{http.Header{}}
 	}
+	return resps
 }