support Private Network Access #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on [this Chrome blog](https://developer.chrome.com/blog/private-network-access-preflight) and the related W3C [draft report](https://wicg.github.io/private-network-access).
|
One omission of this PR is the addition of |
cvermilion
added a commit
to remixlabs/cors
that referenced
this pull request
Oct 3, 2022
This should have been part of rs#127.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this Chrome blog and the related W3C draft report.
If the
Options.AllowPrivateNetworkflag is set, and a preflight request includesAccess-Control-Request-Private-Network, we includeAccess-Control-Allow-Private-Networkin the response. The assumption here is that any origin that we allow CORS requests from is also allowed to access the server via a private network; if you want per-origin logic for this you probably want to write your own CORS handler.Per my understanding of the spec, the header is only added for preflight (OPTIONS) requests.