-
Notifications
You must be signed in to change notification settings - Fork 6
feat(storage): validates CID hash and prepends /ipfs/ #487
Conversation
@rsksmart/rif-marketplace
There is an open issue at jest about this here. The multibase lib have informed react-scripts about it (presumably). Which one is it going to be? |
We can comment the test and resume work later on this once we upgrade to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Comment failing test for now until we upgrade to React 4 (we know we have to do some analysis for this specially around
tasegir
). - Add /ipfs/ also to hash created by Upload File Service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG! I agree with @julianmrodri about re-taking the failing test once we move to react-scripts v4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
What the tin says.
Resolves #468