Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to kotlinx-io and ktor 3.0 #280

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Migrate to kotlinx-io and ktor 3.0 #280

merged 1 commit into from
Nov 30, 2024

Conversation

whyoleg
Copy link
Member

@whyoleg whyoleg commented Nov 11, 2024

Fixes #277 and probably prepares ground for #110 (in some way, if it's possible).
Note: it's breaking change!

  • rsocket-core now depends only on kotlinx.coroutines and kotlinx.io!
  • ByteReadPacket was replaced with Buffer and could be revisited soon for Payload/Metadata API in favor of ByteString or Source
    • Buffer was done to ease migration: it has size and copy support which is needed for Payload API
  • ktor transports updated to 3.0.1
    • wasm and all native targets support will be implemented in next PR
  • leak tracking in tests was removed, as there is no way to do it until Leak tracing mechanism Kotlin/kotlinx-io#144
    • at this moment it's less of an issue, as kotlinx.io.Buffer is backed by ByteArray and so is fully managed by GC

@whyoleg whyoleg self-assigned this Nov 11, 2024
Copy link

github-actions bot commented Nov 11, 2024

Test Results

  878 files    878 suites   38m 40s ⏱️
3 873 tests 3 134 ✅   739 💤 0 ❌
8 328 runs  6 706 ✅ 1 622 💤 0 ❌

Results for commit 9fb16df.

♻️ This comment has been updated with latest results.

@whyoleg whyoleg merged commit aa46c25 into master Nov 30, 2024
16 of 17 checks passed
@whyoleg whyoleg deleted the ktor3 branch November 30, 2024 10:15
@rcd27
Copy link
Contributor

rcd27 commented Nov 30, 2024

Hell yea, let's go! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Ktor 3.0.0
2 participants