Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: proptests for parsing array indices queries #142

Merged
merged 2 commits into from
May 25, 2023
Merged

test: proptests for parsing array indices queries #142

merged 2 commits into from
May 25, 2023

Conversation

V0ldek
Copy link
Member

@V0ldek V0ldek commented May 24, 2023

Issue

Resolves: #51

Checklist

All of these should be ticked off before you submit the PR.

  • I ran just verify locally and it succeeded.
  • Issue was given go ahead and is linked above OR I have included justification for a minor change.
  • Unit tests for my changes are included OR no functionality was changed.

@V0ldek V0ldek requested a review from zwerdlds May 24, 2023 21:20
zwerdlds
zwerdlds approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@zwerdlds zwerdlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor thing, which I think is discretionary. Otherwise, LGTM.

@V0ldek V0ldek merged commit c48a59a into main May 25, 2023
@V0ldek V0ldek deleted the v0ldek/#51-proptests-for-array-index branch May 25, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zwerdlds zwerdlds zwerdlds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proptests for the query parser
2 participants
@V0ldek @zwerdlds