Replace "should" with "is expected to" in Generated Descriptions #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll need to pin this to your expectations PR to pass, which is our normal practise, then we remove the pin when merged. |
orien
approved these changes
Oct 18, 2018
|
History re-written as requested. |
JonRowe
pushed a commit
that referenced
this pull request
Mar 4, 2019
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Nov 2, 2019
Update ruby-rspec-expectations to 3.9.0. pkgsr change: Add "USE_LANGUAGES= # none". ### 3.9.0 / 2019-10-02 [Full Changelog](http://github.com/rspec/rspec-expectations/compare/v3.8.5...v3.9.0) Enhancements: * The `respond_to` matcher now uses the signature from `initialize` to validate checks for `new` (unless `new` is non standard). (Jon Rowe, #1072) * Generated descriptions for matchers now use `is expected to` rather than `should` in line with our preferred DSL. (Pete Johns, #1080, rspec/rspec-core#2572) * Add the ability to re-raise expectation errors when matching with `match_when_negated` blocks. (Jon Rowe, #1130) * Add a warning when an empty diff is produce due to identical inspect output. (Benoit Tigeot, #1126) ### 3.8.6 / 2019-10-07 Bug Fixes: * Revert #1125 due to the change being incompatible with our semantic versioning policy. ### 3.8.5 / 2019-10-02 [Full Changelog](http://github.com/rspec/rspec-expectations/compare/v3.8.4...v3.8.5) Bug Fixes: * Prevent unsupported implicit block expectation syntax from being used. (Phil Pirozhkov, #1125) ### 3.8.4 / 2019-06-10 [Full Changelog](http://github.com/rspec/rspec-expectations/compare/v3.8.3...v3.8.4) Bug Fixes: * Prevent false negatives when checking objects for the methods required to run the the `be_an_instance_of` and `be_kind_of` matchers. (Nazar Matus, #1112)
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
rspec/rspec-core#2572) This commit was imported from rspec/rspec-core@600c6c1.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
rspec/rspec-core#2572) This commit was imported from rspec/rspec-core@e5e4ad7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Described in more detail in rspec/rspec-expectations#1080
Change