Remove DRb client runner #2866
Closed
Remove DRb client runner #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not because there could be a conflict with another server (like spork). |
|
I am unsure about removing something that works, is minimal maintenance, and could potentially have downstream knock ons we wouldn't find out about until it was too late... |
|
It's hard to disagree 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still use DRb in bisect, this remains.
drb_portconfiguration was tangled between the two.Just for bisect, having configurable DRb port seems redundant. Fixed it to 8787 (that seems to be the 'default').
The only project I'm aware of using this was
sporkthat doesn't receive updates for years.