Extend reserved name check #2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
approved these changes
Apr 20, 2021
pirj
reviewed
Apr 20, 2021
|
1.8.7/1.9.2 CI failures are apparently due to |
JonRowe
approved these changes
Apr 21, 2021
|
Can you rebase this? The build was updated with a ruby gems fix which means most legacy rubies should run now |
|
Still red due to RubyGems. |
|
Er apparently I hadn't merged those PRs that mostly fixed CI, my apologies, please rebase from latest main and try again 😹 |
|
Thanks, I'm pretty confident the remaining failures are existing build issues. |
JonRowe
added a commit
that referenced
this pull request
Apr 28, 2021
JonRowe
added a commit
that referenced
this pull request
Apr 28, 2021
…er-names Extend reserved name check
JonRowe
added a commit
that referenced
this pull request
Apr 28, 2021
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…-reserved-memoized-helper-names Extend reserved name check --- This commit was imported from rspec/rspec-core@fa1b5f5.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
This commit was imported from rspec/rspec-core@04d5e52.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 19, 2021
…-reserved-memoized-helper-names Extend reserved name check --- This commit was imported from rspec/rspec-core@6f8ee75.
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 19, 2021
This commit was imported from rspec/rspec-core@780580b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes rspec/rspec-rails#2478
to_sis now also viewed as a reserved name and thus may not be used.This also extends the name check to check against strings rather than just symbols.