Expose configuration options #834
Conversation
|
Just a heads up, there will be a conflict with #867 specifically the Other than that, I think this looks good. |
|
Oh yeah, I still need to review this...will try to get to it soon :). |
|
Closing in favor of #874 (which is just this PR merged into master) |
|
I prefer rebasing and force pushing over merging in another branch, as this preserves the discussion centered around the PR, and I only havent rebased it because I'm still awaiting @myronmarston's feedback... |
|
I can force push to your repo? I wasn't sure how to deal with that. Sorry if I stepped on toes this way - my thinking was I'd fix this PR since I broke it (merge-conflict-wise). FWIW this change gets 👍 to merge into master from me, but also didn't want to step on Myron's toes since this was on his radar. |
|
I just meant it was awaiting more feedback, then I was going to rebase it. You can't push to my repo unless I add you all as collaborators, which actually might be reasonable. |
|
I prefer keeping the extra merge commit out as well, so I'll comment here. |
| @@ -423,6 +424,9 @@ def expect_with(*frameworks) | |||
| @expectation_frameworks.push(*modules) | |||
| end | |||
|
|
|||
| def full_backtrace | |||
| @backtrace_clean_patterns.empty? | |||
| end | |||
| def full_backtrace=(true_or_false) | |||
There was a problem hiding this comment.
Please put blank lines between method defs -- I find that it helps readability a lot.
There was a problem hiding this comment.
Done, sorry, I suck at that.
|
Woops, I accidentally got my chrome tabs confused and left a couple comments on @soulcutter's PR. I might move them over later but I don't have the time right now. |
Conflicts: lib/rspec/core/configuration.rb
| def full_backtrace | ||
| @exclusion_patterns.empty? | ||
| end | ||
|
|
There was a problem hiding this comment.
Given that this is a boolean predicate, maybe it should be full_backtrace?.
…to_config Expose configuration options
|
I left a couple more minor comments, (sorry, some of this stuf I didn't notice until just now), but went ahead and merged because this is definitely a big improvement. If the other comments are deemed worthy of addressing it can always be done post-merge. Can you add a change log entry, though? Thanks! |
|
Added changelog over on #876 |
An alternate to #832 this solves #732 by exposing readers for a few of the configuration options that don't already have them.