Remove non-monkey-patching should syntax, too

Changelog.md

@@ -4,7 +4,8 @@
 Breaking Changes:
 
 * Ruby < 2.3 is no longer supported. (Phil Pirozhkov, #1231)
-* Extract monkey-patching `should*` syntax and globally-exposed DSL. (Phil Pirozhkov, #1245)
+* Extract `should*` (both monkey-patching and non-monkey-patching) syntax and
+  globally-exposed DSL. (Phil Pirozhkov, #1245)
 
 Enhancements:
 

README.md

@@ -216,17 +216,6 @@ expect(
 ).to match([a_hash_including(:a => 'hash'), a_hash_including(:a => 'another')])
 ```
 
-## `should` syntax
-
-In addition to the `expect` syntax, rspec-expectations continues to support the
-non-monkey patching `should` syntax:
-
-```ruby
-subject(:number) { 4 }
-it { should eq(4) }
-it { should be > 3 }
-it { should_not be_odd }
-```
 
 ## Compound Matcher Expressions
 

features/.nav

@@ -16,7 +16,6 @@
   - have_attributes.feature
   - include.feature
   - match.feature
-  - operators.feature
   - raise_error.feature
   - respond_to.feature
   - satisfy.feature

features/customized_message.feature

@@ -1,8 +1,7 @@
 Feature: customized message
 
   RSpec tries to provide useful failure messages, but for cases in which you want more
-  specific information, you can define your own message right in the example.This works for
-  any matcher _other than the operator matchers_.
+  specific information, you can define your own message right in the example.
 
   Scenario: customize failure message
     Given a file named "example_spec.rb" with:

lib/rspec/expectations/handler.rb

@@ -46,8 +46,6 @@ def self.handle_failure(matcher, message, failure_message_method)
     class PositiveExpectationHandler
       def self.handle_matcher(actual, initial_matcher, custom_message=nil, &block)
         ExpectationHelper.with_matcher(self, initial_matcher, custom_message) do |matcher|
-          return ::RSpec::Matchers::BuiltIn::PositiveOperatorMatcher.new(actual) unless initial_matcher
-
           match_result = matcher.matches?(actual, &block)
           if custom_message && match_result.respond_to?(:error_generator)
             match_result.error_generator.opts[:message] = custom_message
@@ -74,8 +72,6 @@ def self.opposite_should_method
     class NegativeExpectationHandler
       def self.handle_matcher(actual, initial_matcher, custom_message=nil, &block)
         ExpectationHelper.with_matcher(self, initial_matcher, custom_message) do |matcher|
-          return ::RSpec::Matchers::BuiltIn::NegativeOperatorMatcher.new(actual) unless initial_matcher
-
           negated_match_result = does_not_match?(matcher, actual, &block)
           if custom_message && negated_match_result.respond_to?(:error_generator)
             negated_match_result.error_generator.opts[:message] = custom_message

lib/rspec/matchers.rb

@@ -501,9 +501,6 @@ def change(receiver=nil, message=nil, &block)
     # This works for collections. Pass in multiple args and it will only
     # pass if all args are found in collection.
     #
-    # @note This is also available using the `=~` operator with `should`,
-    #       but `=~` is not supported with `expect`.
-    #
     # @example
     #   expect([1, 2, 3]).to contain_exactly(1, 2, 3)
     #   expect([1, 2, 3]).to contain_exactly(1, 3, 2)

lib/rspec/matchers/built_in.rb

@@ -35,10 +35,7 @@ module BuiltIn
       autoload :Include,                 'rspec/matchers/built_in/include'
       autoload :All,                     'rspec/matchers/built_in/all'
       autoload :Match,                   'rspec/matchers/built_in/match'
-      autoload :NegativeOperatorMatcher, 'rspec/matchers/built_in/operators'
-      autoload :OperatorMatcher,         'rspec/matchers/built_in/operators'
       autoload :Output,                  'rspec/matchers/built_in/output'
-      autoload :PositiveOperatorMatcher, 'rspec/matchers/built_in/operators'
       autoload :RaiseError,              'rspec/matchers/built_in/raise_error'
       autoload :RespondTo,               'rspec/matchers/built_in/respond_to'
       autoload :Satisfy,                 'rspec/matchers/built_in/satisfy'

spec/rspec/expectations/expectation_target_spec.rb

@@ -68,13 +68,13 @@ module Expectations
         it 'does not support operator matchers from #to' do
           expect {
             expect(3).to == 3
-          }.to raise_error(ArgumentError)
+          }.to raise_error(ArgumentError, /The expect syntax does not support operator matchers, so you must pass a matcher to `#to`/)
         end
 
         it 'does not support operator matchers from #not_to' do
           expect {
             expect(3).not_to == 4
-          }.to raise_error(ArgumentError)
+          }.to raise_error(ArgumentError, /The expect syntax does not support operator matchers, so you must pass a matcher to `#not_to`/)
         end
       end
 

spec/rspec/matchers/built_in/be_spec.rb

@@ -746,20 +746,6 @@ def send
   end
 end
 
-RSpec.describe "should be =~" do
-  subject { "a string" }
-
-  it "passes when =~ operator returns true" do
-    should be =~ /str/
-  end
-
-  it "fails when =~ operator returns false" do
-    expect {
-      should be =~ /blah/
-    }.to fail_with(%(expected: =~ /blah/\n     got:    "a string"))
-  end
-end
-
 RSpec.describe "expect(...).to be ===" do
   it "passes when === operator returns true" do
     expect(Hash).to be === {}