Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output.to_stdout_from_any_process when $stdout has been reassigned #1486

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Sep 19, 2024

  1. Fix output.to_stdout_from_any_process when $stdout has been reassigned

    When running under rspec bisect runner, $stdout & $stderr are reassigned
    to a StringIO, which would introduce spec errors.
    
    ("can't convert Tempfile into StringIO", when trying to reopen the
    stream in CaptureStreamToTempfile)
    
    Since CaptureStreamToTempfile reopens the stream rather than reassigning
    it, I _think_ it makes sense to use STDOUT rather than whatever the
    current value of $stdout is.
    jdelStrother committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3671eb5 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Reassign $stdout/$stderr in CaptureStreamToTempfile

    Otherwise it doesn't work when $stderr has previously been reassigned,
    like in the rspec-core test suite
    jdelStrother committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    392050b View commit details
    Browse the repository at this point in the history