Include backtrace in errors reported by raise_error matcher.
#177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note this depends on rspec/rspec-core#701. @alindeman / @dchelimsky -- can you review? |
| attr_writer :backtrace_formatter | ||
| def backtrace_formatter | ||
| @backtrace_formatter ||= if defined?(::RSpec::Core::Formatters::Helpers) | ||
| ::RSpec::Core::Formatters::Helpers |
There was a problem hiding this comment.
I'd rather expose this more explicitly in RSpec::Core - something like RSpec::Core::BacktraceFormatters. WDYT?
|
One other thing to be fixed here: expect {
blah
}.to raise_error { |e|
expect(e.some_attribute).to eq(some_value)
}In a case like this, if the expectation in the error-matching block fails, the backtrace is not being included in the failure. It'd be cool to find a solution for this (thought it might be complex, in which case I might skip it). |
It's hard to troubleshoot unexpected errors when the backtrace is silenced, as it was previously. Closes #59.
myronmarston
added a commit
that referenced
this pull request
Oct 9, 2012
Include backtrace in errors reported by `raise_error` matcher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard to troubleshoot unexpected errors when the backtrace is silenced,
as it was previously.
Closes #59.