Explain how to set a default driver for system specs #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
reviewed
Oct 4, 2024
JonRowe
reviewed
Oct 4, 2024
|
Thanks for taking the time to improve this! I've suggested a wording change here because what your doing is still manually setting the driver in every test, just with a hook, as a bonus it cleans up the whitespace that is failing CI |
Co-authored-by: Jon Rowe <mail@jonrowe.co.uk>
Co-authored-by: Jon Rowe <mail@jonrowe.co.uk>
|
Thank you @JonRowe - I added a little more to the code example so its clear to add the snippet within the |
Co-authored-by: Nate Matykiewicz <natematykiewicz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current docs explain how to specify the system spec driver for each spec/suite using
driven_by, but I felt it lacked explanation on how to set a default driver for all system specs (especially sinceCapybara.default_driver = ...will not do so).First PR here so please share if I am missing a step in your approval procedure.