Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New added album does not automatically appear in WebUI #27

Closed
rstemmer opened this issue Aug 28, 2019 · 2 comments
Closed

New added album does not automatically appear in WebUI #27

rstemmer opened this issue Aug 28, 2019 · 2 comments
Assignees
Labels
🐞 Bug Crash or unexpected behavior

Comments

@rstemmer
Copy link
Owner

New added album does not automatically appear in WebUI until the artists-list gets updated (for example by triggering the genre selection).

After a new Album/Artist/Song got added or removed from the music collection, the WebUI should update its state to be in sync with the server again.

The mechanics already exists and only need to be applied as an event of a music collection update.

@rstemmer rstemmer added 🐞 Bug Crash or unexpected behavior ‼️ Urgent ‼️ Needs to be fixed ASAP - MusicDB won't work without that fix labels Aug 28, 2019
@rstemmer rstemmer self-assigned this Aug 28, 2019
@rstemmer
Copy link
Owner Author

m( Of cause the Auto-Update interface to notify the server about new added songs already exists. This interface allows to update the internal and WebUI state. It just did not work that day.
I looked at the log file:

 LOG[2019-08-28 07:53:48|DEBUG] musicai.py:LoadModel.107: Create Model for device /gpu:0
 LOG[2019-08-28 07:53:52|INFO ] musicai.py: Prediction took 0:00:39.814247

 LOG[2019-08-28 07:53:52|ERROR] namedpipe.py:ReadLine.101: Reading from FIFO failed with exception "can't concat NoneType to bytes"!

 LOG[2019-08-28 07:54:26|DEBUG] mdbwsi.py:onCall.296: method: request, fncname: SetMDBState, fncsig: UpdateMDBState, arguments: {'category': 'albumfilter', 'name': 'NDH', 'value': False}, pass: None
 LOG[2019-08-28 07:54:26|DEBUG] websocket.py:BroadcastPacket.98: Sending Broadcast Message. (fncname = GetMDBState, fncsig = UpdateMDBState)
 LOG[2019-08-28 07:54:26|DEBUG] mdbwsi.py:onCall.296: method: request, fncname: SetMDBState, fncsig: UpdateMDBState, arguments: {'category': 'albumfilter', 'name': 'NDH', 'value': True}, pass: None
 LOG[2019-08-28 07:54:26|DEBUG] websocket.py:BroadcastPacket.98: Sending Broadcast Message. (fncname = GetMDBState, fncsig = UpdateMDBState)
 LOG[2019-08-28 07:54:27|DEBUG] mdbwsi.py:onCall.296: method: broadcast, fncname: GetFilteredArtistsWithAlbums, fncsig: ShowArtists, arguments: None, pass: None
 LOG[2019-08-28 07:54:27|DEBUG] websocket.py:BroadcastPacket.98: Sending Broadcast Message. (fncname = GetFilteredArtistsWithAlbums, fncsig = ShowArtists)

Direct after the AI did its genre-prediction, an error regarding the FIFI-Interface occured.
Then the manual reload of the artist-list I did by triggering the genre filter is visible.

Problem 1: There is a blind spot. There is no information whats going on around the FIFO-Access.
Problem 2: The FIFO-Interface is far too unreliable. It's not the first time there was an issue with it.

@rstemmer rstemmer removed the ‼️ Urgent ‼️ Needs to be fixed ASAP - MusicDB won't work without that fix label Sep 17, 2019
@rstemmer
Copy link
Owner Author

rstemmer commented Dec 8, 2021

The FIFO interface will be removed with version 8.0.0. It was just not reliable using FIFO files with Python.

When importing an album using the new (comes with 8.0.0) graphical interface inside the WebUI the update process works already reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Crash or unexpected behavior
Projects
None yet
Development

No branches or pull requests

1 participant