Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add dark-mode toggle switch #787
feat: Add dark-mode toggle switch #787
Changes from 6 commits
6653f5e
d9790d6
33f2a08
588d927
723535c
4aa3aea
f9111b3
ff5d96d
e74282c
34552c5
7eb8290
5fc01d7
922912c
433c0c4
a2662e7
e126c82
203cd2e
d2a56f2
824f2e8
5a32c5b
4fe55f4
2214281
8ee16b9
b935225
4a27e8d
9e6845e
18a1cbf
8dda683
c181ea5
492c032
ff5fe08
97d28a5
1b6d36d
715b4c3
b4f0e9c
455b612
8db469f
de2824d
c433453
1c1af63
dc08ca4
cf44138
8682eb8
7898c68
fea680f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we already
importFrom
forlist2()
, andarg_match()
/names2()
is becoming common enough that I'd be inclined to alsoimportFrom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never remember what's imported and what isn't. I'm open to importing just these functions, but if we're adding more imported functions from rlang, I'd rather just
@import rlang
-- which also opens us up to using the rlang type checking functions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I'm OK with that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do that in a separate PR then! 😄
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.