Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build-a-box): Add example value box builder app #790

Merged
merged 66 commits into from
Sep 14, 2023
Merged

Conversation

gadenbuie
Copy link
Member

@gadenbuie gadenbuie commented Sep 7, 2023

image

For #778

To run the app call the following

shiny::runApp(system.file("examples/build-a-box", package = "bslib"))

There's only one external "option" that is controlled by the ENABLE_THEMER envvar. When exactly "true", the themer is included in the app -- it's also minimized on init with a bit of JavaScript (maybe we should add first-class support for controlling how or where the themer UI is inserted).

Sys.setenv("ENABLE_THEMER" = "true")
shiny::runApp(system.file("examples/build-a-box", package = "bslib"))

You can also turn on the themer for a running app by adding ?themer or ?themer=true to the URL and reloading the page.

@gadenbuie gadenbuie marked this pull request as ready for review September 7, 2023 15:43
@gadenbuie gadenbuie requested a review from cpsievert September 7, 2023 15:44
@gadenbuie gadenbuie assigned gadenbuie and unassigned gadenbuie Sep 7, 2023
@cpsievert
Copy link
Collaborator

Probably worth adding rstudio/shiny to the Config/Needs/deploy field in DESCRIPTION (so the dropdowns work better in dark mode)

Copy link
Collaborator

@cpsievert cpsievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So awesome, feel free to merge after the minor suggestions!

@cpsievert
Copy link
Collaborator

cpsievert commented Sep 13, 2023

One other optional nit. I think input_dark_mode() could come out the card and go in the page header (and maybe the same for the code export?)

@gadenbuie
Copy link
Member Author

One other optional nit. I think input_dark_mode() could come out the card and go in the page header (and maybe the same for the code export?)

I like this, thanks for the suggestion!

image

@gadenbuie gadenbuie merged commit 7c72c6d into main Sep 14, 2023
@gadenbuie gadenbuie deleted the feat/box-builder branch September 14, 2023 15:41
@gadenbuie gadenbuie mentioned this pull request Sep 26, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants