Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(value-box): Tweaks for dark mode #791

Merged
merged 4 commits into from
Sep 12, 2023
Merged

feat(value-box): Tweaks for dark mode #791

merged 4 commits into from
Sep 12, 2023

Conversation

gadenbuie
Copy link
Member

  • Use a darker shadow for values boxes (if enabled) in dark mode
  • Updates the shiny preset color adjustments for value box foreground colors to use the new --bslib-color-fg custom props

@gadenbuie gadenbuie changed the title Feat(value-box): Tweaks for dark mode feat(value-box): Tweaks for dark mode Sep 8, 2023
@gadenbuie gadenbuie merged commit 45cb389 into main Sep 12, 2023
@gadenbuie gadenbuie deleted the refresh/value-box-dark branch September 12, 2023 13:54
cpsievert pushed a commit that referenced this pull request Sep 12, 2023
@gadenbuie @cpsievert
feat(value-box): Tweaks for dark mode (#791)
5720f1a
cpsievert pushed a commit that referenced this pull request Sep 12, 2023
@gadenbuie @cpsievert
feat(value-box): Tweaks for dark mode (#791)
3cb6683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregswinehart gregswinehart gregswinehart left review comments

@cpsievert cpsievert cpsievert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gadenbuie @cpsievert @gregswinehart