breaking(layout_column_wrap): Make width
optional but must be named
#853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #799
Addresses posit-dev/py-shiny#732
Breaking: This PR makes
width
an optional argument and moves it to after the...
. A code search shows that most people name thewidth
argument, but in case they haven't we'll test to see if the first argument tolayout_column_wrap()
looks like a validwidth
value (a single numeric value or a valid CSS unit) and we'll emit a deprecation warning and use that first value aswidth
.Note: in the deprecation warning I'm assuming this breaking change will cause our next version to be v0.6.0 (in any case, we should review our deprecation warnings before the next release to make sure we have the right version in them).
Some code to try out this feature: