Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

facebook social share -- proposed fix #234

Closed
richpauloo opened this issue Sep 15, 2019 · 2 comments
Closed

facebook social share -- proposed fix #234

richpauloo opened this issue Sep 15, 2019 · 2 comments

Comments

@richpauloo
Copy link

richpauloo commented Sep 15, 2019 •
edited
Loading

The default social share for facebook currently doesn't work.

To reproduce, visit any example flexdashboard online (such as this one) and attempt to share via Facebook.

Digging into the HTML reveals that the request sent to facebook is:

https://www.facebook.com/sharer/sharer.php?s=100&p[url]="+encodeURIComponent(location.href)

Changing it to the following solves this issue:

https://www.facebook.com/sharer/sharer.php?u="+encodeURIComponent(location.href)
@gadenbuie
Copy link
Member

Thanks! It's a bit hard to find in the Facebook developer docs, but this page seems to agree with you!

gadenbuie added a commit that referenced this issue Mar 1, 2023
@gadenbuie
Add NEWS item for #234
d6f73d0
@gadenbuie
Copy link
Member

Fixed in e239f23, thanks for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gadenbuie @richpauloo