Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock when passing generators to fit() with TF 2.13 #1369

Merged
merged 14 commits into from
Jul 7, 2023

Conversation

t-kalinowski
Copy link
Member

Also, fixes some misc failing tests due to symbols moving.

with keras 2.13, generators are
converted to tf.data pipelines with
a prefetch operation. This caused a deadlock,
where a queue consumer for the generator was
not insync with the main-thread queue producer
scheduled as a keras callback. This removes the callback scheduler
and manual eventloop, defaulting to standard python evaluation semantics,
where we depend on tasks scheduled on the main thread to be able to run
while the main thread is blocked.

related: rstudio/tensorflow#575
@t-kalinowski t-kalinowski merged commit d8c515f into main Jul 7, 2023
16 checks passed
@t-kalinowski
Copy link
Member Author

Related: tensorflow/tensorflow#47321

@t-kalinowski t-kalinowski deleted the fix/generator-deadlock branch December 29, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant