Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow find_chrome() to return all the compatible browsers #227

Open
RLesur opened this issue Apr 26, 2021 · 2 comments
Open

Allow find_chrome() to return all the compatible browsers #227

RLesur opened this issue Apr 26, 2021 · 2 comments
Assignees
Labels
feature a feature request or enhancement

Comments

@RLesur
Copy link
Collaborator

RLesur commented Apr 26, 2021

From @cderv, in #225 (review):

  • do we want to allow a choice ? We could have something like
find_chrome(which = NULL) # default - use first one found - Chrome then MSEdge
find_chrome(which = "all") # returns all paths found - useful to check
find_chrome(which = "chrome") # returns Chrome
find_chrome(which = "msedge") # returns MSEdge

It is not useful for pagedown directly and we could keep the idea if there is a need. I though of that mainly because

  • I tried find_chrome("all") because we support it in blogdown::find_hugo("all")
  • I have chrome AND msedge and I can't really choose which one to use with find_chrome() - it will always use Google Chrome. I need to set explicitly the env var to test EDGE.

So I would use it :)

@RLesur I could make the change in another PR if you think it would be interesting.

@cderv
Copy link
Collaborator

cderv commented Apr 26, 2021

Then I understand this is interesting 😉 I'll do it.

@RLesur
Copy link
Collaborator Author

RLesur commented Apr 26, 2021

Of course! Since I've only a single compatible browser on each of my computers, I had never had this idea but I agree this will be a great improvement in order to test chrome_print().

@cderv cderv added feature a feature request or enhancement and removed enhancement labels Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants